forked from diegoecab/oci-deal-accelerator
ca93a0aa4e
Why this set of changes:
- KB pricing was drifting silently — domain files (database.yaml,
storage.yaml, etc.) had prices 30-800% off the live Oracle API and
nobody read them. The skill was auditing as stale on every check
with no path to fix it.
- The skill itself violated Anthropic's spec (`name` field had
uppercase/spaces) and was over the 500-line guideline (647 lines),
hurting discovery and load performance.
- Welcome flow occasionally improvised the menu instead of reading
SKILL.md, missing options.
Pricing — single source of truth, fully automated:
- Extend tools/refresh_sku_catalog.py with --refresh-domain compute,
pulls shape-level prices from the Oracle public pricing API
(apexapps.oracle.com), preserves manual fields (notes, GPU specs,
free-tier annotations, estimation_helpers), recomputes derived
monthly values, and protects $0 free-tier prices from overwrite.
- Delete 12 redundant pricing/<domain>.yaml files. They duplicated
oci-sku-catalog.yaml with worse abstractions and were nobody's
source of truth (no tool consumed them).
- Migrate the genuinely valuable knowledge from those 12 files
(billing models, BYOL rules, free-tier rules, ECPU vs OCPU,
X11M elastic model, hyperscaler comparisons, service nuances)
into kb/field-knowledge/pricing-knowledge.yaml — non-numeric,
no refresh needed.
- Result: pricing freshness check goes from 13 stale files to 0.
KB freshness automation:
- Add tools/kb_freshness.py — wrapper around kb_linter.check_freshness()
with --check, --auto-refresh, --json, --quiet modes. Bridges stale
files to their refresh tools (SKU catalog, compute domain, arch
center). Wired into the welcome flow as a pre-flight banner that
asks the user before refreshing.
- Fix pre-existing kb_linter bug: it crashed on the 45 multi-doc
YAML files (frontmatter + body pattern) because it used safe_load
instead of safe_load_all. Freshness check was effectively dead.
- Standardize timestamp field: linter now accepts last_verified,
last_updated, and last_refreshed; refresh_arch_catalog writes
last_verified instead of last_refreshed.
- Add make freshness / make freshness-refresh targets.
Skill alignment with Anthropic Agent Skills best practices:
- Rename `name: OCI Deal Accelerator` to `oci-deal-accelerator`
to comply with the [a-z0-9-]{1,64} spec.
- Refactor SKILL.md from 674 to 445 lines via progressive disclosure:
extract WA review output format, ECAL readiness format, and output
conventions into docs/skill/*.md referenced from the main file.
- Add scripts/sync-skill.py + make sync-skill: source of truth is
root SKILL.md, .agents/skills/oci-deal-accelerator/SKILL.md is
auto-generated. make lint validates sync.
- Add evaluations/ with 3 manual baseline scenarios (welcome-flow,
full-proposal, wa-review) per the Anthropic best-practices guidance
to "build evaluations first."
Welcome flow hardening:
- Tighten CLAUDE.md to MANDATE reading SKILL.md before showing the
menu (no improvising), and document the freshness pre-flight check
with the ask-before-refresh user flow.
- Update SKILL.md welcome flow to instruct: parse kb_freshness JSON,
show banner with stale count + oldest file, prompt user to refresh
(only when an automated tool exists), fall back silently on errors.
Linter hygiene (zero remaining issues):
- Expand config/kb-tags.yaml taxonomy with features, operations,
metrics, limitations sections covering 31 previously-unknown tags
used in field findings (rac, ecpu, refreshable-clone, hnsw, etc.).
- Assign owners for kb/compatibility/, kb/competitive/,
kb/well-architected/ (Diego Cabrera as default until team grows);
kb/pricing/ marked as "Auto-refreshed" since it no longer needs
human ownership.
- kb_linter accepts top-level `date` as fallback for contributor
block; migrate FF-202603-008 from legacy `reported_by` to
contributor block.
- Result: linter goes from 45 issues to 0.
Other:
- Recompute estimation_helpers monthly values in compute.yaml after
the price refresh (they were derived from the old E5/A1 numbers).
- Add kb/README.md — contributor guide (directory map, frontmatter
spec, refresh tooling, review cadence).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
83 lines
2.5 KiB
Python
83 lines
2.5 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
Sync SKILL.md (root, source of truth) to .agents/skills/oci-deal-accelerator/SKILL.md.
|
|
|
|
The Codex copy under .agents/ must be byte-identical to the root SKILL.md
|
|
except for an auto-generated banner inserted after the YAML frontmatter.
|
|
|
|
Usage:
|
|
python scripts/sync-skill.py # write the .agents/ copy
|
|
python scripts/sync-skill.py --check # exit 1 if out of sync (for CI/lint)
|
|
"""
|
|
|
|
import argparse
|
|
import os
|
|
import sys
|
|
|
|
PROJECT_ROOT = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
|
|
SOURCE = os.path.join(PROJECT_ROOT, "SKILL.md")
|
|
TARGET = os.path.join(
|
|
PROJECT_ROOT, ".agents", "skills", "oci-deal-accelerator", "SKILL.md"
|
|
)
|
|
|
|
BANNER = (
|
|
"<!-- AUTO-GENERATED FROM /SKILL.md — do not edit directly. "
|
|
"Run `python scripts/sync-skill.py` to regenerate. -->\n"
|
|
)
|
|
|
|
|
|
def render() -> str:
|
|
"""Read root SKILL.md and return the .agents/ version with banner injected."""
|
|
with open(SOURCE, "r", encoding="utf-8") as fh:
|
|
content = fh.read()
|
|
|
|
# Inject banner after the closing `---` of the YAML frontmatter, if present.
|
|
if content.startswith("---\n"):
|
|
end = content.find("\n---\n", 4)
|
|
if end != -1:
|
|
head = content[: end + len("\n---\n")]
|
|
tail = content[end + len("\n---\n") :]
|
|
return head + "\n" + BANNER + tail
|
|
|
|
# No frontmatter — prepend banner.
|
|
return BANNER + content
|
|
|
|
|
|
def cmd_check() -> int:
|
|
expected = render()
|
|
if not os.path.isfile(TARGET):
|
|
print(f"sync-skill: target missing: {TARGET}")
|
|
return 1
|
|
with open(TARGET, "r", encoding="utf-8") as fh:
|
|
actual = fh.read()
|
|
if actual == expected:
|
|
print("sync-skill: OK (in sync)")
|
|
return 0
|
|
print("sync-skill: OUT OF SYNC")
|
|
print(f" source: {SOURCE}")
|
|
print(f" target: {TARGET}")
|
|
print(" run: python scripts/sync-skill.py")
|
|
return 1
|
|
|
|
|
|
def cmd_write() -> int:
|
|
expected = render()
|
|
os.makedirs(os.path.dirname(TARGET), exist_ok=True)
|
|
with open(TARGET, "w", encoding="utf-8") as fh:
|
|
fh.write(expected)
|
|
print(f"sync-skill: wrote {os.path.relpath(TARGET, PROJECT_ROOT)} "
|
|
f"({len(expected.splitlines())} lines)")
|
|
return 0
|
|
|
|
|
|
def main() -> int:
|
|
parser = argparse.ArgumentParser(description="Sync root SKILL.md to .agents/")
|
|
parser.add_argument("--check", action="store_true",
|
|
help="Exit 1 if out of sync; do not write.")
|
|
args = parser.parse_args()
|
|
return cmd_check() if args.check else cmd_write()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|